[U-Boot] help on using patman
Mugunthan V N
mugunthanvnm at ti.com
Thu Feb 4 16:09:15 CET 2016
Hi Simon
I tried to use patman with a sample commit, below is the commit
with the tag patmantest
Commit:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ git show patmantest
tag patmantest
Tagger: Mugunthan V N <mugunthanvnm at ti.com>
Date: Thu Feb 4 11:51:48 2016 +0530
Series-to: me
Series-prefix: RFC
Cover-letter:
Unified command execution in one place
At present two parsers have similar code to execute commands. Also
cmd_usage() is called all over the place. This series adds a single
function which processes commands called cmd_process().
END
commit 02c23a9b585d91272befb8fe43d21fe52e1fd139
Author: Mugunthan V N <mugunthanvnm at ti.com>
Date: Mon Jan 18 14:17:43 2016 +0530
defconfig: dra72_evm: enable disk driver model
Enable disk driver model for dra72_evm as dwc_ahci supports
driver model
Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
Reviewed-by: Tom Rini <trini at konsulko.com>
diff --git a/configs/dra72_evm_defconfig b/configs/dra72_evm_defconfig
index 32d1dc1..7ff2a4e 100644
--- a/configs/dra72_evm_defconfig
+++ b/configs/dra72_evm_defconfig
@@ -24,3 +24,5 @@ CONFIG_DM_SPI=y
CONFIG_DM_SPI_FLASH=y
CONFIG_TIMER=y
CONFIG_OMAP_TIMER=y
+CONFIG_DISK=y
+CONFIG_DWC_AHCI=y
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
But when I patman -n, it throws below error
$ ./tools/patman/patman -n
Cleaned 1 patches
total: 0 errors, 0 warnings, 0 checks, 5 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
Traceback (most recent call last):
File "./tools/patman/patman", line 158, in <module>
options.add_maintainers)
File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/series.py", line 222, in MakeCcFile
raise_on_error=raise_on_error)
File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 321, in BuildEmailList
raw += LookupEmail(item, alias, raise_on_error=raise_on_error)
File "/home/mugunthan/workspace/git/mainline/u-boot-ti/tools/patman/gitutil.py", line 495, in LookupEmail
raise ValueError, msg
ValueError: Alias 'defconfig' not found
Then I tried with patman setting ignore_errors: True and
process_tags: False, then the out seems fine but the tag
is not processed. Do you find any thing I missed?
Output with modified patman settings:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ ./tools/patman/patman -n
Cleaned 1 patches
total: 0 errors, 0 warnings, 0 checks, 5 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
0001-defconfig-dra72_evm-enable-disk-driver-model.patch has no obvious style problems and is ready for submission.
No recipient.
Please add something like this to a commit
Series-to: Fred Bloggs <f.blogs at napier.co.nz>
Or do something like this
git config sendemail.to u-boot at lists.denx.de
Dry run, so not doing much. But I would do this:
Send a total of 1 patch with no cover letter.
0001-defconfig-dra72_evm-enable-disk-driver-model.patch
Cc: u-boot at lists.denx.de
Cc: Lokesh Vutla <lokeshvutla at ti.com>
Version: None
Prefix: None
Here is my patman config
$ cat ~/.patman
[alias]
me: Mugunthan V N <mugunthanvnm at ti.com>
[settings]
ignore_errors: True
process_tags: False
verbose: True
Regards
Mugunthan V N
More information about the U-Boot
mailing list