[U-Boot] [PATCH] imx: imx7 Support for Manufacturing Protection

[Fabio Estevam]

On Wed, Feb 3, 2016 at 8:56 AM, Ulises Cardenas <raul.casas at nxp.com> wrote:

> +/**
> +* generate_mppubk() - Generates a Public for Manufacturing Protection
> +*
> +* Returns zero on success,and negative on error.
> +*/
> +static int genenerate_mppubk(void)
> +{
> +       int ret = 0;
> +
> +       ret = gen_mppubk();
> +
> +       return ret;
> +}

You could simply remove 'ret' and do a return gen_mppubk(); directly,
but maybe you don't even need genenerate_mppubk() and could use
gen_mppubk() directly instead?

> +
> +/**
> +* generate_mpsign() - Example of Signature command  for Manufacturing Protection
> +*
> +* Returns zero on success,and negative on error.
> +*/
> +static int generate_mpsign(void)
> +{
> +       int ret = 0;
> +
> +       ret = sign_mppubk();
> +
> +       return ret;
> +}

Ditto.