[U-Boot] [PATCH] Revert "common/memsize.c: Simplify RAM size detection"

Wolfgang Denk wd at denx.de
Wed Feb 10 10:36:54 CET 2016


Dear Hans,

In message <56BAF2B1.3040507 at redhat.com> you wrote:
> 
> It seems this code was as it was for a reason and that a revert
> of your simplification is probably the best solution.

Indeed. Over the past 15 years I have seen several attempts to
improve or simplify the mesize code.  Most did not make it into
mainline as they worked for the poster, but caused problems on some
other boards.

We had a similar "simplification" in 2012, see commit b8496cce and
revert in 3ab270d5, but all these attempts caused problems of some
kind, so the basic structure of the code is still exactly the same
as in the original version of 2004 (commit c83bf6a2).

Probably this is just Perfect Code (TM) which cannot improved further
:-)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The word "fit", as I understand it, means "appropriate to a purpose",
and I would say the body of the Dean is supremely appropriate to  the
purpose of sitting around all day and eating big heavy meals.
                                 - Terry Pratchett, _Moving Pictures_


More information about the U-Boot mailing list