[U-Boot] [PATCH 2/2] net: phy: marvell: Fix problem with phy_reset() clearing BMCR

Joe Hershberger joe.hershberger at gmail.com
Wed Feb 10 17:11:23 CET 2016


On Wed, Feb 10, 2016 at 12:06 AM, Stefan Roese <sr at denx.de> wrote:
> With commit a058052c [net: phy: do not read configuration register on
> reset], phy_reset() will clear the BMCR register. Resulting in bit 12
> being cleared (A/N enable). This leads to autonegotiation link problems,
> at least on the Marvell Armada ClearFog board. I suspect that other
> boards using this driver will be affected as well.
>
> At the of m88e1111s_config(), phy_reset() is called. This is not needed
> for the PHY to load the changed configuration, as phy_reset() is called
> a few lines before already. So lets call genphy_restart_aneg() here
> instead to start the AN correctly.
>
> Tested on clearfog.
>
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Stefan Agner <stefan at agner.ch>
> Cc: Hao Zhang <hzhang at ti.com>
> Cc: Michal Simek <monstr at monstr.eu>
> Cc: Andy Fleming <afleming at gmail.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list