[U-Boot] [PATCH] arm: at91: Add support for DENX MA5D4 SoM and EVK

[Marek Vasut]

On 02/11/2016 06:52 AM, Heiko Schocher wrote:
> Hello Marek,

Hi!

> added Andreas to cc as he is the at91 custodian.
> 
> Am 10.02.2016 um 22:41 schrieb Marek Vasut:
>> Add support for DENX MA5D4 SoM and MA5D4EVK board, based on the
>> Atmel SAMA5D4 SoC. The SoM contains the SoC, eMMC, SPI NOR, SPI
>> CAN controllers and DRAM, the baseboard contains UART connectors,
>> ethernet port, microSD slot, LCD header, 2x CAN connector and a
>> lot of expansion headers.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Andreas Bießmann <andreas.devel at googlemail.com>

Andreas should be in Cc , see ^ , could it be that the ML is doing
something funny again ?

>> ---
>>   arch/arm/mach-at91/Kconfig      |   6 +
>>   board/denx/ma5d4evk/Kconfig     |  12 ++
>>   board/denx/ma5d4evk/MAINTAINERS |   6 +
>>   board/denx/ma5d4evk/Makefile    |   7 +
>>   board/denx/ma5d4evk/ma5d4evk.c  | 417
>> ++++++++++++++++++++++++++++++++++++++++
>>   configs/ma5d4evk_defconfig      |  11 ++
>>   include/configs/ma5d4evk.h      | 255 ++++++++++++++++++++++++
>>   7 files changed, 714 insertions(+)
>>   create mode 100644 board/denx/ma5d4evk/Kconfig
>>   create mode 100644 board/denx/ma5d4evk/MAINTAINERS
>>   create mode 100644 board/denx/ma5d4evk/Makefile
>>   create mode 100644 board/denx/ma5d4evk/ma5d4evk.c
>>   create mode 100644 configs/ma5d4evk_defconfig
>>   create mode 100644 include/configs/ma5d4evk.h
> 
> just some nitpick ;-)
> 
> [...]
>> diff --git a/board/denx/ma5d4evk/ma5d4evk.c
>> b/board/denx/ma5d4evk/ma5d4evk.c
>> new file mode 100644
>> index 0000000..d1a550e
>> --- /dev/null
>> +++ b/board/denx/ma5d4evk/ma5d4evk.c
>> @@ -0,0 +1,417 @@
>> +/*
>> + * Copyright (C) 2015 Marek Vasut <marex at denx.de>
>> + *
>> + * SPDX-License-Identifier:    GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +#include <asm/io.h>
>> +#include <asm/arch/at91_common.h>
>> +#include <asm/arch/at91_pmc.h>
>> +#include <asm/arch/at91_rstc.h>
>> +#include <asm/arch/atmel_mpddrc.h>
>> +#include <asm/arch/atmel_usba_udc.h>
>> +#include <asm/arch/gpio.h>
>> +#include <asm/arch/clk.h>
>> +#include <asm/arch/sama5d3_smc.h>
>> +#include <asm/arch/sama5d4.h>
>> +#include <atmel_hlcdc.h>
>> +#include <atmel_mci.h>
>> +#include <lcd.h>
>> +#include <mmc.h>
>> +#include <net.h>
>> +#include <netdev.h>
>> +#include <spi.h>
>> +#include <version.h>
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
>> +/*
>> + * re h ; load 0x200000 ma5d4evk/u-boot-spl.bin BIN ; go 0x200000
>> + * h ; load 0x26f00000 ma5d4evk/u-boot.bin BIN ; go 0x26f00000
>> + */
> 
> ;-) Maybe a comment that this are the magic commands in the BDI
> for starting the generated images would be helpful.

Guh, nice catch, removed.

> And plan is to switch to CONFIG_DM for all boards (I know, I did not
> started with this job for "my" boards ...)... do you have plans/time
> for switching (or may you use it already and i just overseen it)?

I'd like to start with MX6 when I have time, but that's not gonna happen
soon I'm afraid. I'm hoping someone from Atmel will take up
the job for Atmel-based boards ;-)

> Beside of this:
> Reviewed-by: Heiko Schocher <hs at denx.de>
> 
> bye,
> Heiko