[U-Boot] [PATCH 1/2] dm: video: Add a temporary work-around for old stdout var

Simon Glass sjg at chromium.org
Thu Feb 11 21:28:10 CET 2016


Hi Stephen,

On 8 February 2016 at 14:09, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 02/06/2016 02:31 PM, Simon Glass wrote:
>>
>> Boards with a saved environment may use 'lcd' in their stdout environment
>> variable, expecting that this will enable output to the LCD. When the
>> board
>> moves to use driver model for video, this will no-longer work. Add a
>> work-around to fix this. A warning messages is printed, and we will remove
>> the work-around at the end of 2016.
>
>
> I tested u-boot-dm/tegra-working which I assume is the same as these
> patches, so the series,
>
> Tested-by: Stephen Warren <swarren at nvidia.com>
>
> But...
>
>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>
>
>> +config VIDCONSOLE_AS_LCD
>> +       bool "Use 'vidconsole' when 'lcd' is seen in stdout"
>> +       depends on DM_VIDEO
>> +       help
>> +         This is a work-around for boards which have 'lcd' in their
>> stdout
>> +         environment variable, but have moved to use driver model for
>> video.
>> +         In this case the console will no-longer work. While it is
>> possible
>> +         to update the environment, the breakage may be confusing for
>> users.
>> +         This option will be removed around the end of 2016.
>
>
> Removing this option at the end of 2016 is simply going to cause the exact
> same problem then. Is there any harm in simply not deprecating this feature?
> I suppose at least there's a warning that people should convert over, so
> perhaps they will and so the chances of people getting bitten by this well
> be less by then.

Also we do need people to keep up with things to some extent.
Otherwise we end up with cruft that confuses people. There is a
prominent run-time message that people will see in the meantime.

What's the status of this series now? I'd like to see if it can be applied.

Regards,
Simon


More information about the U-Boot mailing list