[U-Boot] exclude email by patman

Simon Glass sjg at chromium.org
Fri Feb 12 16:54:16 CET 2016


Hi,

On 9 February 2016 at 11:56, Steve Rae <steve.rae at broadcom.com> wrote:
> On Tue, Feb 9, 2016 at 10:08 AM, york sun <york.sun at nxp.com> wrote:
>
>> On 02/09/2016 09:13 AM, Tom Rini wrote:
>> > On Tue, Feb 09, 2016 at 05:08:35PM +0000, york sun wrote:
>> >> On 02/09/2016 12:00 AM, Wolfgang Denk wrote:
>> >>> Dear York,
>> >>>
>> >>> In message <
>> AM4PR0401MB1732EC48981EED9B70CE23859AD50 at AM4PR0401MB1732.eurprd04.prod.outlook.com>
>> you wrote:
>> >>>>
>> >>>> Is there a way to exclude specific emails from the CC list when using
>> patman?
>> >>>> The no-longer-existed email address got rejected by SMTP server.
>> >>>
>> >>> That';s just papering over the problems, and thus the wrong approach.
>> >>>
>> >>> The correct thing to do is having the wrong addresses fixed or
>> >>> removed.
>> >>
>> >> Dear Wolfgang,
>> >>
>> >> I don't think we are on the same page. When I mention invalid email
>> address, it
>> >> is not the format of email, but the server rejects the address because
>> the
>> >> account has been disabled/deleted. It is not the knowledge patman for
>> git
>> >> send-email can acquire. My current workaround is to send patches
>> manually using
>> >> git send-email.
>> >
>> > No, I think you are on the same page.  Wolfgang is saying we shouldn't
>> > have dead email addresses on file (... where patman picks them up, ie
>> > MAINTAINERS).  In your case, it should only fail on bad freescale/nxp
>> > emails, yes?  Maybe there's more stuff to poke people about and/or drop?
>> >
>>
>> Good we are on the same page. Let me be specific on this issue I am
>> facing. For
>> the RFC patch I posted yesterday http://patchwork.ozlabs.org/patch/580577/,
>> if I
>> run script/get_maintainer.pl,
>>
>> $ perl scripts/get_maintainer.pl
>> 0001-arm-ls1021aqds-Convert-to-driver-model-and-enable-se.patch
>> Albert Aribaud <albert.u.boot at aribaud.net> (maintainer:ARM)
>> Alison Wang <alison.wang at freescale.com> (maintainer:LS1021AQDS BOARD)
>> Hans de Goede <hdegoede at redhat.com>
>>
>> (commit_signer:34/85=40%,authored:21/85=25%,added_lines:97/202=48%,removed_lines:14/47=30%)
>> Simon Glass <sjg at chromium.org>
>>
>> (commit_signer:18/85=21%,authored:5/85=6%,commit_signer:1/2=50%,commit_signer:5/6=83%)
>> Ian Campbell <ijc at hellion.org.uk> (commit_signer:18/85=21%)
>> Stefan Roese <sr at denx.de>
>>
>> (commit_signer:9/85=11%,authored:5/85=6%,added_lines:13/202=6%,removed_lines:3/47=6%)
>> York Sun <york.sun at nxp.com>
>>
>> (commit_signer:8/85=9%,commit_signer:1/2=50%,authored:1/2=50%,commit_signer:1/6=17%,authored:1/6=17%,removed_lines:216/221=98%)
>> Masahiro Yamada <yamada.masahiro at socionext.com>
>> (authored:5/85=6%,removed_lines:5/47=11%)
>> Lokesh Vutla <lokeshvutla at ti.com> (removed_lines:3/47=6%)
>> Bin Meng <bmeng.cn at gmail.com> (commit_signer:1/2=50%,authored:1/2=50%)
>> Haikun Wang <Haikun.Wang at freescale.com>
>> (commit_signer:5/6=83%,authored:5/6=83%,added_lines:221/221=100%)
>> Jagan Teki <jteki at openedev.com> (commit_signer:1/6=17%)
>> u-boot at lists.denx.de (open list)
>>
>> In this list, Haikun Wang is no longer with Freescale/NXP. Since he is not
>> a
>> maintainer, there is nothing to fix. His address is in the commit history
>> and
>> nothing can/should be done to change that.
>>
>> I understand this issue is related to my SMTP server which checks local
>> recipients before accepting emails. I can't be the only one having this
>> trouble.
>>
>> It is not a huge deal if this can't be fixed. I asked to see if there is a
>> quick
>> fix.
>>
>> York
>>
>>
> yes - I am having this issue too; and I have also complaints about me
> cc'ing too many people on my patches!
> So, my work-around is:
> - when patman executes "git send-email --annotate ...", it gives me the
> chance to review my patches (in my editor 'vi')
> - while this is occurring, from my editor ('vi'), I run ":e /tmp/patman.*"
> (there is always only one file...) and I manually update the list of
> emails....
> - then after saving that file, the "git send-email" sends to the
> appropriate people.
>
> Ugly -- but it works!
> Thanks, Steve

Also -m disables the get_maintainer feature altogether.

Do we need to add an email blacklist to work around this problem? I
get it a lot but it doesn't really bother me.

Regards,
Simon


More information about the U-Boot mailing list