[U-Boot] [PATCH 1/6] net: gem: Add support for reading MAC from I2C EEPROM

[Michal Simek]

Hi Bin,

2016-02-14 3:25 GMT+01:00 Bin Meng <bmeng.cn at gmail.com>:

> Hi Michal,
>
> On Sat, Feb 13, 2016 at 6:39 PM, Michal Simek <monstr at monstr.eu> wrote:
> > Add support for reading MAC address from I2C EEPROM.
> >
>
> Is this a feature provided by the GEM MAC IP?
>
> > Signed-off-by: Michal Simek <monstr at monstr.eu>
> > ---
> >
> >  drivers/net/zynq_gem.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c
> > index b3821c31a91d..ace60c901cb5 100644
> > --- a/drivers/net/zynq_gem.c
> > +++ b/drivers/net/zynq_gem.c
> > @@ -627,6 +627,21 @@ static int zynq_gem_remove(struct udevice *dev)
> >         return 0;
> >  }
> >
> > +static int zynq_gem_read_rom_hwaddr(struct udevice *dev)
> > +{
> > +#if defined(CONFIG_ZYNQ_GEM_EEPROM_ADDR) && \
> > +    defined(CONFIG_ZYNQ_GEM_I2C_MAC_OFFSET)
> > +       struct eth_pdata *pdata = dev_get_platdata(dev);
> > +
> > +       if (eeprom_read(CONFIG_ZYNQ_GEM_EEPROM_ADDR,
> > +                       CONFIG_ZYNQ_GEM_I2C_MAC_OFFSET,
> > +                       pdata->enetaddr, ARRAY_SIZE(pdata->enetaddr)))
>
> This call to eeprom_read() looks to me a board-specific feature, that
> an on-board eeprom is used to store the MAC address for the GEM?
>
>
Right. it is board specific feature I can
The question is if this should really go to board specific file
or to be the part of DT binding. I didn't look at the kernel if someone has
some sort of eeprom binding for this case
but I expect local mac addresses via DT are used. Or passing via command
line does it.

Anyway there is mac_read_from_eeprom() but it is ancient one.
Do you any preference for the name of function?

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform