[U-Boot] [PATCH] arm: socfpga: Remove bashisms from qts filter

[Wolfgang Denk]

Dear Marek Vasut,

In message <1455205259-14263-1-git-send-email-marex at denx.de> you wrote:
> Weed out bashisms from the script. The echo -e does not work in dash,
> which is the default /bin/sh in debian .
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> Cc: Chin Liang See <clsee at altera.com>
> Cc: Dalon Westergreen <dwesterg at gmail.com>
> ---
>  arch/arm/mach-socfpga/qts-filter.sh | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach-socfpga/qts-filter.sh
> index 1adfbf7..050d6ba 100755
> --- a/arch/arm/mach-socfpga/qts-filter.sh
> +++ b/arch/arm/mach-socfpga/qts-filter.sh
> @@ -187,13 +187,13 @@ usage() {
>  	echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir] [output_dir]"
>  	echo "Process QTS-generated headers into U-Boot compatible ones."
>  	echo ""
> -	echo -e "  soc_type\t-\tType of SoC, either 'cyclone5' or 'arria5'."
> -	echo -e "  input_qts_dir\t-\tDirectory with compiled Quartus project"
> -	echo -e "\t\t\t\tand containing the Quartus project file (QPF)."
> -	echo -e "  input_bsp_dir\t-\tDirectory with generated bsp containing"
> -	echo -e "\t\t\t\tthe settings.bsp file."
> -	echo -e "  output_dir\t-\tDirectory to store the U-Boot compatible"
> -	echo -e "\t\t\t\theaders."
> +	echo "  soc_type      - Type of SoC, either 'cyclone5' or 'arria5'."
> +	echo "  input_qts_dir - Directory with compiled Quartus project"
> +	echo "                  and containing the Quartus project file (QPF)."
> +	echo "  input_bsp_dir - Directory with generated bsp containing"
> +	echo "                  the settings.bsp file."
> +	echo "  output_dir    - Directory to store the U-Boot compatible"
> +	echo "                  headers."
>  	echo ""
>  }

I always wonder why people go through the efforts to write such long
sequences of echo commands.

Why don't you simply use a here document?  It is much easier to
provide correct formatting there, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A good aphorism is too hard for the tooth of time, and  is  not  worn
away  by  all  the  centuries,  although  it serves as food for every
epoch.                                  - Friedrich Wilhelm Nietzsche
                          _Miscellaneous Maxims and Opinions_ no. 168