[U-Boot] [PATCH 17/30] dm: sandbox: Enable cbfs and cramfs

[Bin Meng]

Hi Simon,

On Mon, Feb 15, 2016 at 10:16 AM, Simon Glass <sjg at chromium.org> wrote:
> Enable these two filesystems to provide better build coverage in sandbox.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  include/configs/sandbox.h | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

One comment below:

>
> diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h
> index 0f02839..2268c4e 100644
> --- a/include/configs/sandbox.h
> +++ b/include/configs/sandbox.h
> @@ -44,6 +44,9 @@
>  #define CONFIG_CMD_FAT
>  #define CONFIG_CMD_EXT4
>  #define CONFIG_CMD_EXT4_WRITE
> +#define CONFIG_CMD_CBFS
> +#define CONFIG_CMD_CRAMFS
> +#define CONFIG_CRAMFS_CMDLINE

It looks CONFIG_CRAMFS_CMDLINE is nothing but a duplicated macro of
CONFIG_CMD_CRAMFS. Maybe a separate patch to drop
CONFIG_CRAMFS_CMDLINE?

>  #define CONFIG_CMD_PART
>  #define CONFIG_DOS_PARTITION
>  #define CONFIG_HOST_MAX_DEVICES 4
> --

Regards,
Bin