[U-Boot] [PATCH v2 02/18] gpio: Add support for Qualcomm gpio controller

[Simon Glass]

Hi,

On 9 February 2016 at 14:25, Jagan Teki <jteki at openedev.com> wrote:
> On 8 February 2016 at 02:27, Mateusz Kulikowski
> <mateusz.kulikowski at gmail.com> wrote:
>> Add support for gpio controllers on Qualcomm Snapdragon devices.
>> This devices are usually called Top Level Mode Multiplexing in
>> Qualcomm documentation.
>>
>> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski at gmail.com>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>> Tested-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> Changes in v3: None
>> Changes in v2:
>> - Reordered includes (again)
>> - Added newlines between returns
>> - Fixed error handling in msm_gpio_probe
>> - Added reviewed-by
>>
>> Changes in v1:
>> - Added dt binding documentation
>> - Added help to KConfig
>> - Use clrsetbits() to switch direction
>> - Fixed include order
>> - Added #defines for registers/register fields
>> - Added secondary compatible string
>>
>>  doc/device-tree-bindings/gpio/gpio-msm.txt |  22 +++++
>>  drivers/gpio/Kconfig                       |  14 +++
>>  drivers/gpio/Makefile                      |   1 +
>>  drivers/gpio/msm_gpio.c                    | 135 +++++++++++++++++++++++++++++
>>  4 files changed, 172 insertions(+)
>>  create mode 100644 doc/device-tree-bindings/gpio/gpio-msm.txt
>>  create mode 100644 drivers/gpio/msm_gpio.c
>>
>> diff --git a/doc/device-tree-bindings/gpio/gpio-msm.txt b/doc/device-tree-bindings/gpio/gpio-msm.txt
>> new file mode 100644
>> index 0000000..966ce0a
>> --- /dev/null
>> +++ b/doc/device-tree-bindings/gpio/gpio-msm.txt
>> @@ -0,0 +1,22 @@
>> +Qualcomm Snapdragon GPIO controller
>> +
>> +Required properties:
>> +- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
>> +- reg : Physical base address and length of the controller's registers.
>> +       This controller is called "Top Level Mode Multiplexing" in
>> +       Qualcomm documentation.
>> +- #gpio-cells : Should be one (pin number).
>> +- gpio-controller : Marks the device node as a GPIO controller.
>> +- gpio-count: Number of GPIO pins.
>> +- gpio-bank-name: (optional) name of gpio bank. As default "soc" is used.
>> +
>> +Example:
>> +
>> +soc_gpios: pinctrl at 1000000 {
>> +       compatible = "qcom,msm8916-pinctrl";
>
> Can't this driver goes into pinctrl (I mean gpio handling pincontrol),
> because Linux handle these gpio msm8916-pinctrl through pinctrl
> subsystem as per as I know, let me know in case if I miss anything
> here.

I think Mateusz is planning to add this later. It would be good to get
this in as a starting point for this platform.

Regards,
Simon