[U-Boot] [PATCH 10/30] dm: blk: Rename get_device() to blk_get_device_str()

Stephen Warren swarren at wwwdotorg.org
Wed Feb 17 00:14:15 CET 2016


On 02/14/2016 07:16 PM, Simon Glass wrote:
> The current name is too generic. The function returns a block device based
> on a provided string. Rename it to aid searching and make its purpose
> clearer. Also add a few comments.

> +int blk_get_device_str(const char *ifname, const char *dev_str,
> +		       struct blk_desc **dev_desc);

Bikeshed: s/_str/_by_str/? Otherwise it somewhat sounds like it returns 
a "device_str" rather than returns a "device" and searches for it using 
a "str".

Of course, this is a really annoying comment that would cause a large 
amount of work, so feel free to ignore it.


More information about the U-Boot mailing list