[U-Boot] [PATCH v2] test/py: only check for SPL signature if SPL uses serial output

Heiko Schocher hs at denx.de
Wed Feb 17 18:30:22 CET 2016


Hello Stephen,

Am 17.02.2016 um 17:45 schrieb Stephen Warren:
> On 02/16/2016 11:48 PM, Heiko Schocher wrote:
>> check for U-Boot SPL signature only if SPL really has a serial output.
>> So check if CONFIG_SPL_SERIAL_SUPPORT is active in board config.
>
> I suspect you didn't test this; it causes all tests to fail on all platforms...

Damn, yes, seems I overlooked this issue, while trying to get
test/py running for the smartweb board.

>> diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
>
>> +            bcfg = u_boot_console.config.buildconfig
>
> I think that should be self.config.buildconfig instead; there is no u_boot_console variable at this
> point in the code.

fixed.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list