[U-Boot] [PATCH] dm: ns16550: Add support for reg-offset property

[Michal Simek]

On 24.2.2016 11:56, Adam Ford wrote:
> On Tue, Feb 23, 2016 at 12:38 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Michal,
>>
>> On 22 February 2016 at 00:40, Michal Simek <michal.simek at xilinx.com> wrote:
>>> On 19.2.2016 21:55, Simon Glass wrote:
>>>> Hi Michal,
>>>>
>>>> On 16 February 2016 at 08:17, Michal Simek <michal.simek at xilinx.com> wrote:
>>>>> reg-offset is the part of standard 8250 binding in the kernel.
>>>>> It is shifting start of address space by reg-offset.
>>>>> On Xilinx platform this offset is typically 0x1000.
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>>> ---
>>>>>
>>>>>  drivers/serial/ns16550.c | 6 ++++--
>>>>>  include/ns16550.h        | 1 +
>>>>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>>>
>>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>>
>>>> Do you support the debug UART feature on your boards?
>>>
>>> yes. I do support it but there you can put just address plus offset and
>>> there is no reason to add one more option to Kconfig.
>>> But let me know if you think that this is incorrect flow.
>>
> 
> This patch seems to break my OMAP3 board.  Does anyone know if I need
> to set a certain offset for OMAP3 to make this work (and where is the
> right place for it) ?

Are you using DT init? Check your DT description if there is reg-offset
property. I expect if your board worked before and you remove this
property it will start to work again.

Thanks,
Michal