[U-Boot] [PATCH] serial: Move carriage return before line feed for some serial drivers

Huan Wang alison.wang at nxp.com
Thu Feb 25 05:58:03 CET 2016


Hi, Bin,

> On Thu, Feb 25, 2016 at 11:02 AM, Huan Wang <alison.wang at nxp.com> wrote:
> > Hi, Bin,
> >
> >> On Thu, Feb 25, 2016 at 10:41 AM, Alison Wang <b18965 at freescale.com>
> >> wrote:
> >> > In general, a carriage return needs to execute before a line feed.
> >> > The patch is to change some serial drivers based on this rule, such
> >> > as serial_mxc.c, serial_pxa.c, serial_s3c24x0.c and usbtty.c.
> >> >
> >> > Signed-off-by: Alison Wang <alison.wang at nxp.com>
> >> > ---
> >> >  drivers/serial/serial_mxc.c     | 8 ++++----
> >> >  drivers/serial/serial_pxa.c     | 8 ++++----
> >> >  drivers/serial/serial_s3c24x0.c | 8 ++++----
> >> >  drivers/serial/usbtty.c         | 7 ++++---
> >> >  4 files changed, 16 insertions(+), 15 deletions(-)
> >> >
> >>
> >> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> >>
> >> I guess dm serial drivers will be in another patch?
> >>
> > [Alison Wang] Yes, two patches.
> >
> 
> I would suggest in the future you send all these 3 patches (serial-ulass,
> legacy serial, dm serial) in a series. This helps people to track.
> 
[Alison Wang] dm serial? Sorry, I may misunderstand you. I only have 2 patches, one is
for serial-ulass(that's my meaning about dm serial), the other is for legacy serial.
I didn't find such error in other dm serial drivers.

Best Regards,
Alison Wang


More information about the U-Boot mailing list