[U-Boot] [PATCH] serial: Move carriage return before line feed for some serial drivers

Bin Meng bmeng.cn at gmail.com
Fri Feb 26 02:30:39 CET 2016


Hi Marek,

On Fri, Feb 26, 2016 at 1:55 AM, Marek Vasut <marex at denx.de> wrote:
> On 02/25/2016 03:41 AM, Alison Wang wrote:
>> In general, a carriage return needs to execute before a line feed.
>> The patch is to change some serial drivers based on this rule, such
>> as serial_mxc.c, serial_pxa.c, serial_s3c24x0.c and usbtty.c.
>>
>> Signed-off-by: Alison Wang <alison.wang at nxp.com>
>
> Why isn't this CR-LF stuff handled in common code instead ? It'd be much
> better than having billion copies of the exact same logic (some of them
> more buggy than the others) in drivers.
>

The CR-LF stuff is already handled in the common code, but only for
the DM version, see serial-uclass.c. This patch is to fix non-DM
version serial drivers. When those drivers get converted to DM, these
handling should be removed.

Regards,
Bin


More information about the U-Boot mailing list