[U-Boot] [PATCH v4 01/11] thunderx: Calculate TCR dynamically

[Simon Glass]

Hi,

On 25 February 2016 at 17:49, Alexander Graf <agraf at suse.de> wrote:
> Based on the memory map we can determine a lot of hard coded fields of
> TCR, like the maximum VA and max PA we want to support. Calculate those
> dynamically to reduce the chance for pit falls.
>
> Signed-off-by: Alexander Graf <agraf at suse.de>
> ---
>  arch/arm/cpu/armv8/cache_v8.c    | 59 +++++++++++++++++++++++++++++++++++++++-
>  arch/arm/include/asm/armv8/mmu.h |  6 +---
>  include/configs/thunderx_88xx.h  |  3 --
>  3 files changed, 59 insertions(+), 9 deletions(-)

This approach (extern variable) looks good to me.

Reviewed-by: Simon Glass <sjg at chromium.org>

I didn't know ARRAY_SIZE() worked on external variables, so I leaned
something also.

Regards,
Simon