[U-Boot] [PATCH] serial: Move carriage return before line feed for some serial drivers

Marek Vasut marex at denx.de
Fri Feb 26 10:45:57 CET 2016


On 02/26/2016 02:56 AM, Simon Glass wrote:
> Hi Marek,
> 
> On 25 February 2016 at 10:55, Marek Vasut <marex at denx.de
> <mailto:marex at denx.de>> wrote:
>> On 02/25/2016 03:41 AM, Alison Wang wrote:
>>> In general, a carriage return needs to execute before a line feed.
>>> The patch is to change some serial drivers based on this rule, such
>>> as serial_mxc.c, serial_pxa.c, serial_s3c24x0.c and usbtty.c.
>>>
>>> Signed-off-by: Alison Wang <alison.wang at nxp.com
> <mailto:alison.wang at nxp.com>>
>>
>> Why isn't this CR-LF stuff handled in common code instead ? It'd be much
>> better than having billion copies of the exact same logic (some of them
>> more buggy than the others) in drivers.
>>
> 
> With driver model it is.

OK, thanks.



More information about the U-Boot mailing list