[U-Boot] [PATCH v4 01/11] thunderx: Calculate TCR dynamically

[Simon Glass]

Hi Alexander,

On 26 February 2016 at 01:58, Alexander Graf <agraf at suse.de> wrote:
>
>
>> Am 26.02.2016 um 03:51 schrieb Simon Glass <sjg at chromium.org>:
>>
>> Hi,
>>
>>> On 25 February 2016 at 17:49, Alexander Graf <agraf at suse.de> wrote:
>>> Based on the memory map we can determine a lot of hard coded fields of
>>> TCR, like the maximum VA and max PA we want to support. Calculate those
>>> dynamically to reduce the chance for pit falls.
>>>
>>> Signed-off-by: Alexander Graf <agraf at suse.de>
>>> ---
>>> arch/arm/cpu/armv8/cache_v8.c    | 59 +++++++++++++++++++++++++++++++++++++++-
>>> arch/arm/include/asm/armv8/mmu.h |  6 +---
>>> include/configs/thunderx_88xx.h  |  3 --
>>> 3 files changed, 59 insertions(+), 9 deletions(-)
>>
>> This approach (extern variable) looks good to me.
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> I didn't know ARRAY_SIZE() worked on external variables, so I leaned
>> something also.
>
> It doesn't. Could you please point me to a case where I'm still using ARRAY_SIZE in v4? I thought I had moved everything to null-terminating entries.

I imagined some gcc linker sizeof() magic. Oh well.

See near the top of get_tcr() - the patch on this thread.

Regards,
Simon