[U-Boot] [PATCH 4/7 v2] pci/layerscape: add support for LUT

[Stuart Yoder]

> -----Original Message-----
> From: Minghuan Lian
> Sent: Thursday, February 25, 2016 11:56 PM
> To: Stuart Yoder <stuart.yoder at nxp.com>; u-boot at lists.denx.de
> Cc: york sun <york.sun at nxp.com>; Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>;
> Mingkai Hu <mingkai.hu at nxp.com>; Yang-Leo Li <leoyang.li at nxp.com>; marc.zyngier at arm.com;
> Stuart Yoder <stuart.yoder at nxp.com>
> Subject: RE: [PATCH 4/7 v2] pci/layerscape: add support for LUT
> 
> Hi Stuart,
> 
> Please see my comments inline.
> 
> Thanks,
> Minghuan
> 
> > -----Original Message-----
> > From: Stuart Yoder [mailto:stuart.yoder at nxp.com]
> > Sent: Friday, February 26, 2016 7:06 AM
> > To: u-boot at lists.denx.de
> > Cc: york sun <york.sun at nxp.com>; Prabhakar Kushwaha
> > <prabhakar.kushwaha at nxp.com>; Mingkai Hu <mingkai.hu at nxp.com>;
> > Minghuan Lian <minghuan.lian at nxp.com>; Yang-Leo Li <leoyang.li at nxp.com>;
> > marc.zyngier at arm.com; Stuart Yoder <stuart.yoder at nxp.com>
> > Subject: [PATCH 4/7 v2] pci/layerscape: add support for LUT
> >
> > From: Stuart Yoder <stuart.yoder at nxp.com>
> >
> > The per-PCI controller LUT (Look-Up-Table) is a 32-entry table
> > that maps PCI requester IDs (bus/dev/fun) to a stream ID.
> >
> > This patch implements infrastructure to enable LUT initialization:
> >   -define registers offsets
> >   -add an index to 'struct ls_pcie' to track next available slot in LUT
> >   -add function to allocate the next available entry index
> >   -add function to program a LUT entry
> >
> > Signed-off-by: Stuart Yoder <stuart.yoder at nxp.com>
> > ---
> > -v2
> >   -no changes
> >
> >  drivers/pci/pcie_layerscape.c |   36
> > ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> >
> > diff --git a/drivers/pci/pcie_layerscape.c b/drivers/pci/pcie_layerscape.c
> > index bb29222..6886488 100644
> > --- a/drivers/pci/pcie_layerscape.c
> > +++ b/drivers/pci/pcie_layerscape.c
> > @@ -58,6 +58,13 @@
> >  #define PCIE_ATU_FUNC(x)		(((x) & 0x7) << 16)
> >  #define PCIE_ATU_UPPER_TARGET		0x91C
> >
> > +/* LUT registers */
> > +#define PCIE_LUT_BASE		0x80000
> [Minghuan Lian] PCIE_LUT_BASE has been defined in immap_lsch2.h and immap_lsch3.h.
> LS1043a has the different base address.
> 
> > +#define PCIE_LUT_UDR(n)         (0x800 + (n) * 8)
> > +#define PCIE_LUT_LDR(n)         (0x804 + (n) * 8)
> > +#define PCIE_LUT_ENABLE         (1 << 31)
> > +#define PCIE_LUT_ENTRY_COUNT    32
> > +

I'll move the new defines into immap_lsch3.h.

Stuart