[U-Boot] [PATCH 8/9] Allow command-line files to be dropped

Simon Glass sjg at chromium.org
Fri Feb 26 18:31:33 CET 2016


Hi Tom,

On 26 February 2016 at 10:17, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Feb 25, 2016 at 09:00:55PM -0700, Simon Glass wrote:
>
>> These files do not need to be compiled when CONFIG_CMDLINE is disabled.
>> Update the Makefile to reflect this.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Reviewed-by: Tom Rini <trini at konsulko.com>
>
> ... but did you buildman the world here?  iirc, we have some cases that
> fake running a command to make something important happen here.

Not on this commit, but for the series. I will though.

It is definitely possible that enabling the option will create build
errors. For one, you need a board_run_command() function to be
present. I've tested it for sandbox and am actually thinking of adding
a sandbox board without commands.

Regards,
Simon


More information about the U-Boot mailing list