[U-Boot] [PATCH 15/30] dm: part: Rename some partition functions

Simon Glass sjg at chromium.org
Mon Feb 29 05:19:00 CET 2016


Hi Bin,

On 16 February 2016 at 07:25, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Mon, Feb 15, 2016 at 10:16 AM, Simon Glass <sjg at chromium.org> wrote:
>> Rename three partition functions so that they start with part_. This makes
>> it clear what they relate to.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  board/cm5200/fwupdate.c   |  2 +-
>>  cmd/ide.c                 |  6 +++---
>>  cmd/mmc.c                 |  2 +-
>>  cmd/part.c                |  8 ++++----
>>  cmd/read.c                |  2 +-
>>  cmd/sata.c                |  6 +++---
>>  cmd/scsi.c                |  6 +++---
>>  cmd/usb.c                 |  4 ++--
>>  common/fb_mmc.c           | 10 +++++-----
>>  common/spl/spl_ext.c      |  6 ++----
>>  common/spl/spl_mmc.c      |  2 +-
>>  common/usb_storage.c      |  2 +-
>>  disk/part.c               | 12 ++++++------
>>  disk/part_amiga.c         |  4 ++--
>>  disk/part_dos.c           | 19 +++++++++----------
>>  disk/part_efi.c           | 10 +++++-----
>>  disk/part_iso.c           | 17 +++++++++--------
>>  disk/part_mac.c           |  4 ++--
>>  drivers/block/pata_bfin.c |  2 +-
>>  drivers/block/sandbox.c   |  2 +-
>>  drivers/block/systemace.c |  2 +-
>>  drivers/dfu/dfu_mmc.c     |  2 +-
>>  drivers/mmc/mmc.c         |  2 +-
>>  fs/fat/fat.c              |  2 +-
>>  include/part.h            | 21 ++++++++++-----------
>>  25 files changed, 76 insertions(+), 79 deletions(-)
>>
>
> [snip]
>
>> diff --git a/disk/part_amiga.c b/disk/part_amiga.c
>> index 0f569f0..d323b4b 100644
>> --- a/disk/part_amiga.c
>> +++ b/disk/part_amiga.c
>> @@ -291,7 +291,7 @@ static struct partition_block *find_partition(struct blk_desc *dev_desc,
>>  /*
>>   * Get info about a partition
>>   */
>> -static int get_partition_info_amiga(struct blk_desc *dev_desc, int part,
>> +static int part_get_info_amiga(struct blk_desc *dev_desc, int part,
>>                                     disk_partition_t *info)
>>  {
>>      struct partition_block *p = find_partition(dev_desc, part-1);
>> @@ -382,7 +382,7 @@ static void print_part_amiga(struct blk_desc *dev_desc)
>>  U_BOOT_PART_TYPE(amiga) = {
>>         .name           = "AMIGA",
>>         .part_type      = PART_TYPE_AMIGA,
>> -       .get_info       = get_partition_info_amiga,
>> +       .get_info       = part_get_info_amiga,
>>         .print          = print_part_amiga,
>>         .test           = test_part_amiga,
>
> Can we rename these two to: part_print_amiga and part_test_amiga too?

Yes I'll do these renames in a separate patch for v2.

[snip]

Regards,
Simon


More information about the U-Boot mailing list