[U-Boot] [PATCH 14/30] dm: part: Convert partition API use to linker lists

Simon Glass sjg at chromium.org
Mon Feb 29 05:48:33 CET 2016


Hi Stephen,

On 16 February 2016 at 23:41, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 02/14/2016 07:16 PM, Simon Glass wrote:
>> We can use linker lists instead of explicitly declaring each function.
>> This makes the code shorter by avoiding switch() statements and lots of
>> header file declarations.
>>
>> While this does clean up the code it introduces a few code issues with SPL.
>> SPL never needs to print partition information since this all happens from
>> commands. SPL mostly doesn't need to obtain information about a partition
>> either, except in a few cases. Add these cases so that the code will be
>> dropped from each partition driver when not needed. This avoids code bloat.
>>
>> I think this is still a win, since it is not a bad thing to be explicit
>> about which features are used in SPL. But others may like to weigh in.
>
> This patch changes the order in which partition types are detected,
> which matters when multiple partition types match (a GPT often/always
> has a protective MBR too). Consequently, this breaks GPT support.
>
> By hacking around this (turning off DOS partition support), and fixing
> the PCIe issue I mentioned elsewhere, test/py seems to work for me with
> this series applied.

Thanks for finding this and for your comment on the other patch too.
I'll fix the ordering for v2.

Regards,
Simon


More information about the U-Boot mailing list