[U-Boot] [PATCH 1/1] am33xx: Update serial platdata to update reg_offset to 0

Lokesh Vutla a0131933 at ti.com
Mon Feb 29 10:33:14 CET 2016



On Monday 29 February 2016 02:55 PM, Mugunthan V N wrote:
> With commit: d9a3bec682f9 "dm: ns16550: Add support for reg-offset property"
> reg_offset is added to the struct ns16550_platdata to be
> dt compatible with Linux kernel driver, TI AM335x evms are broken
> as the serial platdata updates wrong offsets. Correcting it with
> initializing reg_offset to zero.

Acked-by: Lokesh Vutla <lokeshvutla at ti.com>

This will be true for OMAP5+ platforms as well. I guess that array also
needs to be updated?

Thanks and regards,
Lokesh

> 
> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
> ---
> 
> Verified the patch on AM335x BBB ad AM335x EVMsk.
> 
> ---
>  arch/arm/cpu/armv7/am33xx/board.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/am33xx/board.c b/arch/arm/cpu/armv7/am33xx/board.c
> index e8d5be3..2963b3b 100644
> --- a/arch/arm/cpu/armv7/am33xx/board.c
> +++ b/arch/arm/cpu/armv7/am33xx/board.c
> @@ -40,14 +40,14 @@ DECLARE_GLOBAL_DATA_PTR;
>  
>  #if !CONFIG_IS_ENABLED(OF_CONTROL)
>  static const struct ns16550_platdata am33xx_serial[] = {
> -	{ CONFIG_SYS_NS16550_COM1, 2, CONFIG_SYS_NS16550_CLK },
> +	{ CONFIG_SYS_NS16550_COM1, 0, 2, CONFIG_SYS_NS16550_CLK },
>  # ifdef CONFIG_SYS_NS16550_COM2
> -	{ CONFIG_SYS_NS16550_COM2, 2, CONFIG_SYS_NS16550_CLK },
> +	{ CONFIG_SYS_NS16550_COM2, 0, 2, CONFIG_SYS_NS16550_CLK },
>  #  ifdef CONFIG_SYS_NS16550_COM3
> -	{ CONFIG_SYS_NS16550_COM3, 2, CONFIG_SYS_NS16550_CLK },
> -	{ CONFIG_SYS_NS16550_COM4, 2, CONFIG_SYS_NS16550_CLK },
> -	{ CONFIG_SYS_NS16550_COM5, 2, CONFIG_SYS_NS16550_CLK },
> -	{ CONFIG_SYS_NS16550_COM6, 2, CONFIG_SYS_NS16550_CLK },
> +	{ CONFIG_SYS_NS16550_COM3, 0, 2, CONFIG_SYS_NS16550_CLK },
> +	{ CONFIG_SYS_NS16550_COM4, 0, 2, CONFIG_SYS_NS16550_CLK },
> +	{ CONFIG_SYS_NS16550_COM5, 0, 2, CONFIG_SYS_NS16550_CLK },
> +	{ CONFIG_SYS_NS16550_COM6, 0, 2, CONFIG_SYS_NS16550_CLK },
>  #  endif
>  # endif
>  };
> 


More information about the U-Boot mailing list