[U-Boot] [PATCH v2] arm: mxs: add support for I2SE's Duckbill boards

Marek Vasut marex at denx.de
Sun Jan 3 21:44:14 CET 2016


On Sunday, January 03, 2016 at 03:56:01 PM, Stefano Babic wrote:
> Hi Michael,
> 
> some aditional comments before you will send V3:

[...]

> > diff --git a/board/i2se/duckbill/Makefile b/board/i2se/duckbill/Makefile
> > new file mode 100644
> > index 0000000..b5577e3
> > --- /dev/null
> > +++ b/board/i2se/duckbill/Makefile
> > @@ -0,0 +1,12 @@
> > +#
> > +# (C) Copyright 2014-2015
> > +# Michael Heimpold, mhei at heimpold.de.
> > +#
> > +# SPDX-License-Identifier:	GPL-2.0+
> > +#
> > +
> > +ifndef	CONFIG_SPL_BUILD
> > +obj-y	:= duckbill.o
> > +else
> > +obj-y	:= iomux.o
> > +endif

All the MXS boards should use spl.o , since it's not only iomux in there.

> Well, it is okay if you want to maintain the name, but iomux is one of
> the most used name for files. What about duckbill-iomux ?
> 
[...]

Best regards,
Marek Vasut


More information about the U-Boot mailing list