[U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel

Bin Meng bmeng.cn at gmail.com
Fri Jan 8 01:02:36 CET 2016


Hi Fabio,

On Fri, Jan 8, 2016 at 12:49 AM, Fabio Estevam <festevam at gmail.com> wrote:
> On Thu, Jan 7, 2016 at 2:28 PM, Tom Rini <trini at konsulko.com> wrote:
>> On Thu, Jan 07, 2016 at 11:31:06AM -0200, Fabio Estevam wrote:
>>> On Thu, Jan 7, 2016 at 10:58 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>
>>> > Ah, yes! Sorry I wanted to say the original proposal to "return 0"
>>> > instead. But now I failed to understand why this fixed the issue
>>> > because those error numbers are not zero.
>>>
>>> The problem only happens if we return a negative value.
>>>
>>> > And why returning zero is bad? From a working PCIe controller (either
>>>
>>> It is not bad, but I still prefer to keep in sync with the kernel driver.
>>
>> And would allow further features later on?
>
> That's correct, Tom.

What new feature would benefit from this? These two PCIe drivers are
non-DM drivers and DM PCI is not utilizing those error codes, instead
DM PCI is using U-Boot standard error codes.

Regards,
Bin


More information about the U-Boot mailing list