[U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel

Fabio Estevam festevam at gmail.com
Fri Jan 8 01:15:13 CET 2016


On Thu, Jan 7, 2016 at 10:02 PM, Bin Meng <bmeng.cn at gmail.com> wrote:

> What new feature would benefit from this? These two PCIe drivers are
> non-DM drivers and DM PCI is not utilizing those error codes, instead
> DM PCI is using U-Boot standard error codes.

but what prevents DM PCI to use the kernel error codes in the future?

Returning PCIBIOS_DEVICE_NOT_FOUND when the config is invalid is a
common pattern in the kernel.

Take a look at these drivers:

drivers/pci/access.c
drivers/pci/host/pci-mvebu.c
drivers/pci/host/pci-xgene.c
drivers/pci/host/pcie-altera.c
drivers/pci/host/pcie-designware.c
drivers/pci/host/pcie-rcar.c
drivers/pci/xen-pcifront.c

I don't see why we can't do the same in U-boot.

Feel free to submit a patch with your proposal and the maintainer can
then decide which one is more adequate for U-boot.


More information about the U-Boot mailing list