[U-Boot] [PATCH 02/14] test: Add a simple script to run tests on sandbox

Teddy Reed teddy.reed at gmail.com
Sun Jul 3 22:41:39 CEST 2016


Hi Simon,

On Sun, Jul 3, 2016 at 8:40 AM, Simon Glass <sjg at chromium.org> wrote:
> A common check before sending patches is to run all available tests on
> sandbox. But everytime I do this I have to look up the README. This presents
> quite a barrier to actually doing this.
>
> Add a shell script to help. To run the tests, type:
>
>    test/run
>
> in the U-Boot directory, which should be easy to remember.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>

Reviewed-by: Teddy Reed <teddy.reed at gmail.com>

> ---
>
>  test/README | 11 +++++++++++
>  test/run    |  4 ++++
>  2 files changed, 15 insertions(+)
>  create mode 100755 test/run
>
> diff --git a/test/README b/test/README
> index dfd83d6..6cfee05 100644
> --- a/test/README
> +++ b/test/README
> @@ -5,6 +5,17 @@ U-Boot has a large amount of code. This file describes how this code is
>  tested and what tests you should write when adding a new feature.
>
>
> +Running tests
> +-------------
> +
> +To run most tests on sandbox, type this:

To run most tests on _the_ sandbox?

> +
> +    test/run
> +
> +in the U-Boot directory. Note that only the pytest suite is run using this
> +comment.

s/comment/command/

> +
> +
>  Sandbox
>  -------
>  U-Boot can be built as a user-space application (e.g. for Linux). This
> diff --git a/test/run b/test/run
> new file mode 100755
> index 0000000..a6dcf8f
> --- /dev/null
> +++ b/test/run
> @@ -0,0 +1,4 @@
> +#!/bin/sh
> +
> +# Run all tests
> +./test/py/test.py --bd sandbox --build
> --
> 2.8.0.rc3.226.g39d4020
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

This seems reasonable, but would a make target be easier: make sandbox_test?

-- 
Teddy Reed V


More information about the U-Boot mailing list