[U-Boot] [RESEND PATCH] rockchip: add basic support for evb-rk3288 board

[Ziyuan Xu]

On 2016年07月09日 22:39, Simon Glass wrote:
> On 5 July 2016 at 04:06, Ziyuan Xu <xzy.xu at rock-chips.com> wrote:
>> evb-3288 board RK3288-based development board with 2 USB ports, HDMI,
>> VGA, micro-SD card, audio, WiFi and Gigabit Ethernet. It also includes
>> on-board 8G eMMC and 2GB of SDRAM. Expansion connector provide access to
>> display pins, I2C, SPI, UART and GPIOs. This add some basic files
>> required to allow the board to output serial messaged and can run
>> command(mmc info etc).
>>
>> evb-rk3288 also supports booting from eMMC or SD card, the default is eMMC.
>>
>> Signed-off-by: Ziyuan Xu <xzy.xu at rock-chips.com>
>>
>> ---
>>
>>   arch/arm/dts/Makefile                     |   1 +
>>   arch/arm/dts/rk3288-evb.dts               |  59 +++++
>>   arch/arm/dts/rk3288-evb.dtsi              | 379 ++++++++++++++++++++++++++++++
>>   arch/arm/mach-rockchip/rk3288-board-spl.c |   4 +-
>>   arch/arm/mach-rockchip/rk3288/Kconfig     |  10 +
>>   board/evb-rk3288/evb-rk3288/Kconfig       |  15 ++
>>   board/evb-rk3288/evb-rk3288/MAINTAINERS   |   6 +
>>   board/evb-rk3288/evb-rk3288/Makefile      |   7 +
>>   board/evb-rk3288/evb-rk3288/evb-rk3288.c  |  15 ++
>>   configs/evb-rk3288_defconfig              |  67 ++++++
>>   doc/README.rockchip                       |   3 +-
>>   include/configs/evb-rk3288.h              |  26 ++
>>   12 files changed, 590 insertions(+), 2 deletions(-)
>>   create mode 100644 arch/arm/dts/rk3288-evb.dts
>>   create mode 100644 arch/arm/dts/rk3288-evb.dtsi
>>   create mode 100644 board/evb-rk3288/evb-rk3288/Kconfig
>>   create mode 100644 board/evb-rk3288/evb-rk3288/MAINTAINERS
>>   create mode 100644 board/evb-rk3288/evb-rk3288/Makefile
>>   create mode 100644 board/evb-rk3288/evb-rk3288/evb-rk3288.c
>>   create mode 100644 configs/evb-rk3288_defconfig
>>   create mode 100644 include/configs/evb-rk3288.h
>>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> small nit below.
>
> [snip]
>
>> diff --git a/board/evb-rk3288/evb-rk3288/evb-rk3288.c b/board/evb-rk3288/evb-rk3288/evb-rk3288.c
>> new file mode 100644
>> index 0000000..a82f0ae
>> --- /dev/null
>> +++ b/board/evb-rk3288/evb-rk3288/evb-rk3288.c
>> @@ -0,0 +1,15 @@
>> +/*
>> + * (C) Copyright 2016 Rockchip Electronics Co., Ltd
>> + *
>> + * SPDX-License-Identifier:     GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +#include <spl.h>
>> +
>> +void board_boot_order(u32 *spl_boot_list)
>> +{
>> +       /* eMMC prior to sdcard. */
> nit: Can you drop the .?
okay, I wil drop it in next patch. Also add reviewed-by tag if you have 
not another dissent.
Thanks!
>
>> +       spl_boot_list[0] = BOOT_DEVICE_MMC2;
>> +       spl_boot_list[1] = BOOT_DEVICE_MMC1;
>> +}
> snip]
>
> Regards,
> Simon
>
>
>