[U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses

[Hans de Goede]

Hi,

On 10-07-16 10:15, Ian Campbell wrote:
> On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote:
>> Currently we fill ethaddr with a fixed unique address based on the
>> SoCs
>> serial (from the sid) to make sure that boards which use the
>> integrated
>> emac / gmac get a fixed mac rather then a random one.
>>
>> On some boards the wifi does not come with a fixed mac either, so we
>> need
>> to also set eth1addr.
>>
>> This commit changes the ethaddr setting code to check for ethernet%d
>> aliases (as fdt_fixup_ethernet does) and set an ethaddr variable for
>> all present aliases.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Acked-by: Ian Campbell <ijc at hellion.org.uk>
>
>> [...]
>> +static void setup_environment(const void *fdt)
>
> It might be worth adding a commit to this function noting that it must
> remain idempotent.

Done, although I avoided the use of the word idempotent, I had to google
it to make sure it meant what I thought it meant, so using a simpler
description for us non native Enlgish speakers seemed better :)

Regards,

Hans