[U-Boot] [PATCH 1/3] COSMETIC: mmc: sdhci: Add CONFIG_ prefix to SDHCI_READ_STATUS_TIMEOUT
Lukasz Majewski
l.majewski at samsung.com
Tue Jul 12 14:24:11 CEST 2016
Hi Tom,
> On Mon, Jul 11, 2016 at 02:49:03PM +0200, Lukasz Majewski wrote:
>
> > This change gives common prefix for SDHCI_READ_STATUS_TIMEOUT.
> >
> > Signed-off-by: Lukasz Majewski <l.majewski at samsung.com>
>
> Hang on, didn't we just intentionally not CONFIG_ this option and not
> add it to Kconfig?
Apparently, I was not aware of such intentions :-).
I do agree that we should add new options to Kconfig, so with second
thoughts I think that this patch was not so good idea...
> If we're making these tunable they need to be in
> Kconfig and if needed, non-asked questions, ie:
> int SDHCI_READ_STATUS_TIMEOUT
> default 100 if FOO_PLATFORM
> default 500 if BAR_PLATFORM
> default 1000
>
> Thanks!
>
BTW: I'm testing Jeahoon's patches for fixing this issue, so probably
this patch series could be dropped.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
More information about the U-Boot
mailing list