[U-Boot] [PATCH 4/8] xtensa: add core information for the dc233c processor

[Simon Glass]

Hi Max,

On 8 July 2016 at 09:42, Max Filippov <jcmvbkbc at gmail.com> wrote:
> Signed-off-by: Max Filippov <jcmvbkbc at gmail.com>
> ---

Commit message?

>  arch/xtensa/include/asm/arch-dc233c/core.h    | 475 ++++++++++++++++++++++++++
>  arch/xtensa/include/asm/arch-dc233c/tie-asm.h | 193 +++++++++++
>  arch/xtensa/include/asm/arch-dc233c/tie.h     | 150 ++++++++
>  3 files changed, 818 insertions(+)
>  create mode 100644 arch/xtensa/include/asm/arch-dc233c/core.h
>  create mode 100644 arch/xtensa/include/asm/arch-dc233c/tie-asm.h
>  create mode 100644 arch/xtensa/include/asm/arch-dc233c/tie.h
>
> diff --git a/arch/xtensa/include/asm/arch-dc233c/core.h b/arch/xtensa/include/asm/arch-dc233c/core.h
> new file mode 100644
> index 0000000..3a2e53b
> --- /dev/null
> +++ b/arch/xtensa/include/asm/arch-dc233c/core.h
> @@ -0,0 +1,475 @@
> +/*
> + * xtensa/config/core-isa.h -- HAL definitions that are dependent on Xtensa
> + *                             processor CORE configuration
> + *
> + *  See <xtensa/config/core.h>, which includes this file, for more details.
> + */
> +
> +/* Xtensa processor core configuration information.
> +
> +   Copyright (c) 1999-2010 Tensilica Inc.
> +
> +   Permission is hereby granted, free of charge, to any person obtaining
> +   a copy of this software and associated documentation files (the
> +   "Software"), to deal in the Software without restriction, including
> +   without limitation the rights to use, copy, modify, merge, publish,
> +   distribute, sublicense, and/or sell copies of the Software, and to
> +   permit persons to whom the Software is furnished to do so, subject to
> +   the following conditions:
> +
> +   The above copyright notice and this permission notice shall be included
> +   in all copies or substantial portions of the Software.
> +
> +   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> +   EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> +   MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
> +   IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
> +   CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
> +   TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
> +   SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.  */

*/ on next line

Can you use SPDX for this?

> +
> +#ifndef _XTENSA_CORE_CONFIGURATION_H
> +#define _XTENSA_CORE_CONFIGURATION_H
> +
> +
> +/****************************************************************************
> +           Parameters Useful for Any Code, USER or PRIVILEGED
> + ****************************************************************************/

Would be better without all this * and - stuff I think.

[snip]

Regards,
Simon