[U-Boot] [PATCH 0/2] efi_loader: Implement reset on RPi

[Andreas Färber]

Hi Alex,

Am 05.06.2016 um 23:17 schrieb Alexander Graf:
> If Linux finds an EFI implementation it always uses the EFI reset handler to
> reboot or power down the system.

Hm, I thought my powerdown issues on the Jetson TK1 were for lack of
CONFIG_AS3277_RESET - sounds like it could be due to EFI instead?

> Unfortunately we haven't implemented that one yet. In fact, while we prepared
> for RTS handling, we never actually implemented a single user.
> 
> This is going to change today. This simple patch set enables RTS reset support
> for the RPi systems, allowing you to reboot and shut down the rpi if booted
> via EFI.
> 
> It also lays the groundwork to show how to implement that functionality at all,
> so I expect more boards to follow.
> 
> Alexander Graf (2):
>   efi_loader: Allow boards to implement get_time and reset_system
>   ARM: bcm283x: Implement EFI RTS reset_system
> 
>  arch/arm/mach-bcm283x/include/mach/wdog.h |   2 +-
>  arch/arm/mach-bcm283x/reset.c             |  59 +++++++++++++++--
>  cmd/bootefi.c                             |   4 ++
>  include/efi_loader.h                      |  18 ++++++
>  lib/efi_loader/efi_runtime.c              | 101 ++++++++++++++++++++++++++----
>  5 files changed, 166 insertions(+), 18 deletions(-)

This all looks very non-generic and would mean that every board will
need to be patched individually, which is unrealistic to be tested by
just the two of us.

Can't you patch the reset_cpu() declaration (common.h/sysreset.h)
instead of all its implementations? We might still need to patch
individual implementations but I don't see why any reset_cpu()
implementation should be in a different section than others.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)