[U-Boot] [PATCH 3/8] xtensa: add core information for the dc232b processor

[Simon Glass]

Hi Max,

On 14 July 2016 at 17:15, Max Filippov <jcmvbkbc at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Jul 12, 2016 at 03:56:46PM -0600, Simon Glass wrote:
>> On 8 July 2016 at 09:42, Max Filippov <jcmvbkbc at gmail.com> wrote:
>> > From: Chris Zankel <chris at zankel.net>
>>
>> Commit message?
>
> Ok, will add.
>
>> >
>> > Signed-off-by: Chris Zankel <chris at zankel.net>
>> > Signed-off-by: Max Filippov <jcmvbkbc at gmail.com>
>> > ---
>> >  arch/xtensa/include/asm/arch-dc232b/core.h    | 422 ++++++++++++++++++++++++++
>> >  arch/xtensa/include/asm/arch-dc232b/tie-asm.h | 120 ++++++++
>> >  arch/xtensa/include/asm/arch-dc232b/tie.h     | 129 ++++++++
>> >  3 files changed, 671 insertions(+)
>> >  create mode 100644 arch/xtensa/include/asm/arch-dc232b/core.h
>> >  create mode 100644 arch/xtensa/include/asm/arch-dc232b/tie-asm.h
>> >  create mode 100644 arch/xtensa/include/asm/arch-dc232b/tie.h
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> nits below.
>>

>> > +/*----------------------------------------------------------------------
>>
>> Do we need all these lines and stars?
>
> These files are autogenerated, so I tried to avoid editing them.
> Sure I can remove these lines and start if absolutely necessary.

If it is auto-generated, can you add a comment to that effect
(including the tool that generated), or better yet, update the tool to
emit that comment? Do you expect it to be regenerated later, or will
edits be done as normal patches? Is there a source file and tool that
you could submit instead, so that the build system creates the
auto-generated source?

Regards,
Simon