[U-Boot] [PATCH v4 2/4] usb: dwc2-otg: adjust fifo size via platform data

[Simon Glass]

Hi Marek,

On 15 July 2016 at 23:43, Marek Vasut <marex at denx.de> wrote:
> On 07/15/2016 05:56 AM, Simon Glass wrote:
>>
>> On 14 July 2016 at 21:20, Simon Glass <sjg at chromium.org> wrote:
>>>
>>> On 14 July 2016 at 00:52, Ziyuan Xu <xzy.xu at rock-chips.com> wrote:
>>>>
>>>> From: Xu Ziyuan <xzy.xu at rock-chips.com>
>>>>
>>>> The total FIFO size of some SoCs may be different from the existen, this
>>>> patch supports fifo size setting from platform data.
>>>>
>>>> Signed-off-by: Ziyuan Xu <xzy.xu at rock-chips.com>
>>>>
>>>> ---
>>>>
>>>> Changes in v4:
>>>> - Rework fifo size getting and setting
>>>> - Update commit message
>>>>
>>>> Changes in v3: None
>>>> Changes in v2:
>>>> - Update detailed commit message
>>>> - Modify the macro's values
>>>>
>>>>  drivers/usb/gadget/dwc2_udc_otg.c      | 22 ++++++++++++++++------
>>>>  drivers/usb/gadget/dwc2_udc_otg_regs.h |  6 +++---
>>>>  include/usb/dwc2_udc.h                 |  3 +++
>>>>  3 files changed, 22 insertions(+), 9 deletions(-)
>>>
>>>
>>> Acked-by: Simon Glass <sjg at chromium.org>
>>
>>
>> Applied to u-boot-rockchip, thanks!
>>
>
> Simon, I see you're now picking generic usb gadget code via platform tree.
> This is NOT OK, there is a tree for usb gadget code and this should go
> through that tree. I would be glad if this didn't repeat.

Ah OK, sorry. I'll leave those alone from now on. Which one is it?

http://www.denx.de/wiki/U-Boot/Custodians

Are the patches OK as applied, or are there more comments?

Regards,
Simon