[U-Boot] [PATCH 6/9] rockchip: rk3188: Add header files for PMU and GRF

Simon Glass sjg at chromium.org
Sun Jul 17 16:13:48 CEST 2016


Hi Heiko,

On 15 July 2016 at 16:17, Heiko Stuebner <heiko at sntech.de> wrote:
> PMU is the power management unit and GRF is the general register file. Both
> are heavily used in U-Boot. Add header files with register definitions.
>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>  arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 589 ++++++++++++++++++++++++
>  arch/arm/include/asm/arch-rockchip/pmu_rk3188.h |  36 ++
>  2 files changed, 625 insertions(+)
>  create mode 100644 arch/arm/include/asm/arch-rockchip/grf_rk3188.h
>  create mode 100644 arch/arm/include/asm/arch-rockchip/pmu_rk3188.h

Acked-by: Simon Glass <sjg at chromium.org>

It's unfortunate that I got the mask value wrong. It should be:

      SW_ADDR16_EN_SHIFT      = 4,
      SW_ADDR16_EN_MASK       = 1 << SW_ADDR16_EN_SHIFT,

since that makes the C code simpler in the common case. It also makes
it an actual mask.

- Simon


More information about the U-Boot mailing list