[U-Boot] [PATCH v2 5/5] mpc85xx/powerpc: Do not apply errata A006261 for T4160, T1040, T2080

[york sun]

On 07/17/2016 08:47 PM, Sriram Dash wrote:
> Do not apply errata A006261 for T4160 and T4080(rev 1.0, 2.0),
> T1040(rev 1.0), T2080(rev 1.0), T2081(rev 1.0).

I don't see mentioning the revision numbers helps here. Your patch is 
removing the erratum from T4160, T4080, T1040, T1042, T1020, T1022, 
T2080, T2081. It would be much clear if you put all A006261 related 
patches into one, and list all the SoCs affected by this erratum since 
the official released document contradicts with your list.

York


>
> Signed-off-by: Sriram Dash <sriram.dash at nxp.com>
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat at nxp.com>
> ---
>  arch/powerpc/include/asm/config_mpc85xx.h | 4 +---
>  drivers/usb/common/fsl-errata.c           | 7 -------
>  2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/config_mpc85xx.h b/arch/powerpc/include/asm/config_mpc85xx.h
> index 9b7feda..6d845e8 100644
> --- a/arch/powerpc/include/asm/config_mpc85xx.h
> +++ b/arch/powerpc/include/asm/config_mpc85xx.h
> @@ -641,6 +641,7 @@
>  #define CONFIG_SYS_NUM_FM2_DTSEC	8
>  #define CONFIG_SYS_NUM_FM2_10GEC	2
>  #define CONFIG_NUM_DDR_CONTROLLERS	3
> +#define CONFIG_SYS_FSL_ERRATUM_A006261
>  #else
>  #define CONFIG_SYS_NUM_FM1_DTSEC	6
>  #define CONFIG_SYS_NUM_FM1_10GEC	1
> @@ -682,7 +683,6 @@
>  #define CONFIG_SYS_FSL_ERRATUM_A004468
>  #define CONFIG_SYS_FSL_ERRATUM_A_004934
>  #define CONFIG_SYS_FSL_ERRATUM_A005871
> -#define CONFIG_SYS_FSL_ERRATUM_A006261
>  #define CONFIG_SYS_FSL_ERRATUM_A006379
>  #define CONFIG_SYS_FSL_ERRATUM_A007186
>  #define CONFIG_SYS_FSL_ERRATUM_A006593
> @@ -800,7 +800,6 @@ defined(CONFIG_PPC_T1020) || defined(CONFIG_PPC_T1022)
>  #define CONFIG_SYS_FSL_PCIE_COMPAT	"fsl,qoriq-pcie-v2.4"
>  #define CONFIG_SYS_FSL_USB_DUAL_PHY_ENABLE
>  #define CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY
> -#define CONFIG_SYS_FSL_ERRATUM_A006261
>  #define CONFIG_SYS_CCSRBAR_DEFAULT	0xfe000000
>  #define CONFIG_SYS_FSL_ERRATUM_ESDHC111
>  #define ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE
> @@ -908,7 +907,6 @@ defined(CONFIG_PPC_T1014) || defined(CONFIG_PPC_T1013)
>  #define CONFIG_SYS_FSL_SFP_VER_3_0
>  #define CONFIG_SYS_FSL_ISBC_VER		2
>  #define CONFIG_SYS_FSL_ERRATUM_ESDHC111
> -#define CONFIG_SYS_FSL_ERRATUM_A006261
>  #define CONFIG_SYS_FSL_ERRATUM_A006593
>  #define CONFIG_SYS_FSL_ERRATUM_A007186
>  #define CONFIG_SYS_FSL_ERRATUM_A006379
> diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c
> index 765b25a..972016c 100644
> --- a/drivers/usb/common/fsl-errata.c
> +++ b/drivers/usb/common/fsl-errata.c
> @@ -64,14 +64,7 @@ bool has_erratum_a006261(void)
>  	case SVR_P5021:
>  		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 2, 0);
>  	case SVR_T4240:
> -	case SVR_T4160:
> -	case SVR_T4080:
>  		return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 2, 0);
> -	case SVR_T1040:
> -		return IS_SVR_REV(svr, 1, 0);
> -	case SVR_T2080:
> -	case SVR_T2081:
> -		return IS_SVR_REV(svr, 1, 0);
>  	case SVR_P5040:
>  		return IS_SVR_REV(svr, 1, 0) ||
>  			IS_SVR_REV(svr, 2, 0) || IS_SVR_REV(svr, 2, 1);
>