[U-Boot] [PATCH] mmc: dw_mmc: reduce timeout detection cycle

Jaehoon Chung jh80.chung at samsung.com
Tue Jul 19 04:03:03 CEST 2016


Hi Ziyuan,

On 07/19/2016 10:38 AM, Ziyuan Xu wrote:
> It's no need to speed 10 seconds to wait the mmc device out from busy
> status. 500 milliseconds enough.

I agreed that 10 seconds is too big..
Could you explain more how you get 500ms and feel enough?

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Ziyuan Xu <xzy.xu at rock-chips.com>
> ---
> 
>  drivers/mmc/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 2cf7bae..790a166 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -195,7 +195,7 @@ static int dwmci_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>  	ALLOC_CACHE_ALIGN_BUFFER(struct dwmci_idmac, cur_idmac,
>  				 data ? DIV_ROUND_UP(data->blocks, 8) : 0);
>  	int ret = 0, flags = 0, i;
> -	unsigned int timeout = 100000;
> +	unsigned int timeout = 500;
>  	u32 retry = 100000;
>  	u32 mask, ctrl;
>  	ulong start = get_timer(0);
> 



More information about the U-Boot mailing list