[U-Boot] [PATCH] i2c: intel_i2c: SMBus driver PCI addition (e.g. BayTrail)

Bin Meng bmeng.cn at gmail.com
Tue Jul 19 06:39:16 CEST 2016


Simon, Heiko,

On Tue, Jul 12, 2016 at 1:22 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Jun 28, 2016 at 9:44 PM, Stefan Roese <sr at denx.de> wrote:
>> This patch adds support for the SMBus block read/write functionality.
>> Other protocols like the SMBus quick command need to get added
>> if this is needed.
>>
>> This patch also removed the SMBus related defines from the Ivybridge
>> pch.h header. As they are integrated in this driver and should be
>> used from here. This change is added in this patch to avoid compile
>> breakage to keep the source git bisectable.
>>
>> Tested on a congatec BayTrail board to configure the SMSC2513 USB
>> hub.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Bin Meng <bmeng.cn at gmail.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Heiko Schocher <hs at denx.de>
>> ---
>> Simon, I'm not sure if this change breaks your Ivybridge targets
>> using the probe part of this driver. Could you please let me
>> know if this works? Or let me know what needs changes here?
>>
>
> Can you test this patch on Ivybridge to see if it breaks anything? Is
> SMBus used on Ivybridge for the memory initialization (eg: reading
> SPD?)
>

Do you have any review comments before it's applied? I believe this
needs to be tested on Ivybridge at least.

Regards,
Bin


More information about the U-Boot mailing list