[U-Boot] [PATCH v2] dm: clk: Remove simple version of clk_get_by_index/name()

Michal Simek michal.simek at xilinx.com
Tue Jul 19 08:22:11 CEST 2016


Hi Simon,

On 18.7.2016 13:20, Simon Glass wrote:
> Hi Michal,
> 
> On 18 July 2016 at 00:57, Michal Simek <michal.simek at xilinx.com> wrote:
>> Hi Simon,
>>
>> On 15.7.2016 17:43, Stephen Warren wrote:
>>> On 07/15/2016 01:02 AM, Michal Simek wrote:
>>>> Simple version of clk_get_by_index() added by:
>>>> "dm: clk: Add a simple version of clk_get_by_index()"
>>>> (sha1: a4b10c088c4f6ef2e2bba33e8cfea369bcbbce44)
>>>> is only working for #clock-cells=<1> but not for
>>>> any other values. Fixed clocks is using #clock-cells=<0>
>>>> which requires full implementation.
>>>>
>>>> Remove simplified versions of clk_get_by_index() and use full version.
>>>> Also remove empty clk_get_by_name() which is failing when it is called
>>>> which is useless.
>>>
>>> This seems reasonable to me,
>>> Acked-by: Stephen Warren <swarren at nvidia.com>
>>
>> I see your patch
>> "dm: clk: Add support for of-platdata"
>> (sha1:  7423daa60eb30b6613dfc19a51c55de23fd4d703)
>> has been merged to the tree and it is in conflict with this patch.
>> Is there any problem about using full version and just remove the whole
>> SPL part?
> 
> Yes I was going to mention that. Unfortunately we need the of-platdata
> version since in that case there is no device tree (it has been
> converted to a C struct).

v3 sent which address this.

Thanks,
Michal



More information about the U-Boot mailing list