[U-Boot] [PATCH] mmc: fix the output format

Jaehoon Chung jh80.chung at samsung.com
Tue Jul 19 12:35:36 CEST 2016


Hi Ziyuan,

On 07/19/2016 07:14 PM, Ziyuan Xu wrote:
> It's nicer to see this:
> 
> => mmc list
> dwmmc at ff0c0000: 0
> dwmmc at ff0f0000: 1 (eMMC)
> 
> than this:
> 
> => mmc list
> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
> 
> With the latter, it's much clearer which mmc devices are on.

You're right. After applied your patch, it may display like mmc-legacy type.
If add the comment in more detail, 
How about "Display mmc list information like mmc-legacy type." ? :)

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Ziyuan Xu <xzy.xu at rock-chips.com>
> ---
> 
>  drivers/mmc/mmc-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 38ced41..beebc70 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
>  
>  	for (uclass_first_device(UCLASS_MMC, &dev);
>  	     dev;
> -	     uclass_next_device(&dev)) {
> +	     uclass_next_device(&dev), first = false) {
>  		struct mmc *m = mmc_get_mmc_dev(dev);
>  
>  		if (!first) {
> 



More information about the U-Boot mailing list