[U-Boot] [PATCH] arch-mx6: fix MX6_PAD_DECLARE macro to work with MX6 duallite
Stefano Babic
sbabic at denx.de
Wed Jul 20 09:30:57 CEST 2016
Hi Hannes,
this patch breaks most i.MX6 boards (the not DL) and I revert it. Maybe
I had to ask better before, anyway:
On 22/06/2016 12:07, Hannes Schmelzer wrote:
> if we build for an i.mx6 (d)ual(l)ite CONFIC_MX6DL we shall use
> MX6DL_PAD instead the common MX6_PAD.
>
> Signed-off-by: Hannes Schmelzer <oe5hpm at oevsv.at>
> ---
>
> arch/arm/include/asm/arch-mx6/mx6-pins.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-mx6/mx6-pins.h b/arch/arm/include/asm/arch-mx6/mx6-pins.h
> index 4b6bb18..3465205 100644
> --- a/arch/arm/include/asm/arch-mx6/mx6-pins.h
> +++ b/arch/arm/include/asm/arch-mx6/mx6-pins.h
> @@ -18,7 +18,7 @@ enum {
> #include "mx6q_pins.h"
> #undef MX6_PAD_DECL
> #define MX6_PAD_DECL(name, pco, mc, mm, sio, si, pc) \
> - MX6_PAD_DECLARE(MX6DL_PAD_,name, pco, mc, mm, sio, si, pc),
> + MX6_PAD_DECLARE(MX6DL_PAD_, name, pco, mc, mm, sio, si, pc),
> #include "mx6dl_pins.h"
> };
> #elif defined(CONFIG_MX6Q)
> @@ -30,7 +30,7 @@ enum {
> #elif defined(CONFIG_MX6DL) || defined(CONFIG_MX6S)
> enum {
> #define MX6_PAD_DECL(name, pco, mc, mm, sio, si, pc) \
> - MX6_PAD_DECLARE(MX6_PAD_,name, pco, mc, mm, sio, si, pc),
> + MX6_PAD_DECLARE(MX6DL_PAD_, name, pco, mc, mm, sio, si, pc),
> #include "mx6dl_pins.h"
> };
Can you better explain the problem you had ? The name is not decisive -
the important thing is that the correct include file with the right
layout is included, that means mx6dl_pins.h. And this was mainlined
since a lot of time.
We have several boards with 6DL into mainline, so I am missing which is
your problem.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
More information about the U-Boot
mailing list