[U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

Jaehoon Chung jh80.chung at samsung.com
Thu Jul 21 04:11:11 CEST 2016


Hi Ziyuan,

On 07/19/2016 11:21 PM, Ziyuan Xu wrote:
> From: Xu Ziyuan <xzy.xu at rock-chips.com>
> 
> It's nicer to see this:
> 
> => mmc list
> dwmmc at ff0c0000: 0
> dwmmc at ff0f0000: 1 (eMMC)
> 
> than this:
> 
> => mmc list
> dwmmc at ff0c0000: 0dwmmc at ff0f0000: 1 (eMMC)
> 
> With the latter, it's much clearer which mmc devices are on.

Right? "With latter"?

> 
> Signed-off-by: Ziyuan Xu <xzy.xu at rock-chips.com>
> 
> Serise-changes: 2
> - Update commit from Jaehoon

Could you add the Changelog to the below line?

> 
> Signed-off-by: Ziyuan Xu <jk.kernel at gmail.com>
> ---

Locate the Changelog at here.

Best Regards,
Jaehoon Chung

> 
>  drivers/mmc/mmc-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 38ced41..beebc70 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
>  
>  	for (uclass_first_device(UCLASS_MMC, &dev);
>  	     dev;
> -	     uclass_next_device(&dev)) {
> +	     uclass_next_device(&dev), first = false) {
>  		struct mmc *m = mmc_get_mmc_dev(dev);
>  
>  		if (!first) {
> 



More information about the U-Boot mailing list