[U-Boot] [PATCH] spl: Fix compilation warnings for arm64

Simon Glass sjg at chromium.org
Fri Jul 22 05:21:23 CEST 2016


Hi Michael,

On 18 July 2016 at 01:07, Michal Simek <michal.simek at xilinx.com> wrote:
> Hi Simon,
>
> On 17.7.2016 16:12, Simon Glass wrote:
>> Hi Michal,
>>
>> On 15 July 2016 at 00:48, Michal Simek <michal.simek at xilinx.com> wrote:
>>> Make code 64bit aware.
>>>
>>> Warnings:
>>> +../arch/arm/lib/spl.c: In function ‘jump_to_image_linux’:
>>> +../arch/arm/lib/spl.c:63:3: warning: cast to pointer from integer of
>>> different size [-Wint-to-pointer-cast]
>>> +../common/spl/spl_fat.c: In function ‘spl_load_image_fat’:
>>> +../common/spl/spl_fat.c:91:33: warning: cast to pointer from integer
>>> of different size [-Wint-to-pointer-cast]
>>>
>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>> ---
>>>
>>>  arch/arm/lib/spl.c   | 2 +-
>>>  common/spl/spl_fat.c | 3 ++-
>>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> You could use map_sysmem() / unmap_sysmem() to convert a ulong address
>> into a pointer.
>
> Isn't this used more for remapping with non zero length?
> I see in the code that people are using it just for conversion but the
> question is if this is right usage.

You are supposed to unmap afterwards. Is that not possible?

Regards,
Simon


More information about the U-Boot mailing list