[U-Boot] [PATCH 2/2] ARM64: rockchip: Add initial support for RK3368 based GeekBox

[Simon Glass]

Hi,

On 18 July 2016 at 06:13, Heiko Stübner <heiko at sntech.de> wrote:
> Hi Andreas,
>
> Am Montag, 18. Juli 2016, 03:06:07 schrieb Andreas Färber:
>> The RK3368 is an octa-core Cortex-A53 SoC from Rockchip.
>>
>> The GeekBox is a TV box from GeekBuying, based on an MXM3 module.
>> The module can be used with base boards such as the GeekBox Landingship.
>>
>> This adds basic support to chain-load U-Boot from Rockchip's miniloader.
>>
>>   $ ./lollipop_u-boot/tools/loaderimage --pack u-boot.bin u-boot.img
>>   # ./utils/upgrade_tool di uboot u-boot.img
>>
>> Implemented is the serial console, but no boot media drivers yet.
>>
>> Note that flashing the resulting U-Boot will not allow you to enter the
>> rockusb mode any more via "Update" button. Instead, you will need to
>> short two pins on the bottom of the module to enter MaskRom mode and
>> re-flash the loader:
>>
>>   # ./utils/upgrade_tool ul ./lollipop_u-boot/RK3368MiniLoaderAll_V2.40.bin
>>   # ./utils/upgrade_tool di uboot u-boot.img
>>
>> Signed-off-by: Andreas Färber <afaerber at suse.de>
>> ---
>>  arch/arm/Kconfig                       |  4 ---
>>  arch/arm/dts/rk3368.dtsi               |  1 +
>>  arch/arm/mach-rockchip/Kconfig         | 14 ++++++++++
>>  arch/arm/mach-rockchip/Makefile        |  1 +
>>  arch/arm/mach-rockchip/rk3368/Kconfig  | 14 ++++++++++
>>  arch/arm/mach-rockchip/rk3368/Makefile |  7 +++++
>>  arch/arm/mach-rockchip/rk3368/rk3368.c | 28 ++++++++++++++++++++
>>  board/geekbuying/geekbox/Kconfig       | 15 +++++++++++
>>  board/geekbuying/geekbox/Makefile      |  7 +++++
>>  board/geekbuying/geekbox/geekbox.c     | 26 +++++++++++++++++++
>>  configs/geekbox_defconfig              | 20 +++++++++++++++
>>  include/configs/geekbox.h              | 19 ++++++++++++++
>>  include/configs/rk3368_common.h        | 47
>> ++++++++++++++++++++++++++++++++++ 13 files changed, 199 insertions(+), 4
>> deletions(-)
>>  create mode 100644 arch/arm/mach-rockchip/rk3368/Kconfig
>>  create mode 100644 arch/arm/mach-rockchip/rk3368/Makefile
>>  create mode 100644 arch/arm/mach-rockchip/rk3368/rk3368.c
>>  create mode 100644 board/geekbuying/geekbox/Kconfig
>>  create mode 100644 board/geekbuying/geekbox/Makefile
>>  create mode 100644 board/geekbuying/geekbox/geekbox.c
>>  create mode 100644 configs/geekbox_defconfig
>>  create mode 100644 include/configs/geekbox.h
>>  create mode 100644 include/configs/rk3368_common.h
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index f9fddad..4ff1a26 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -838,14 +838,10 @@ config STM32
>>
>>  config ARCH_ROCKCHIP
>>       bool "Support Rockchip SoCs"
>> -     select SUPPORT_SPL
>> -     select SPL
>>       select OF_CONTROL
>>       select BLK
>>       select DM
>> -     select SPL_DM
>>       select SYS_MALLOC_F
>> -     select SPL_SYS_MALLOC_SIMPLE
>>       select DM_GPIO
>>       select DM_I2C
>>       select DM_MMC
> [...]
>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>> index 86b77f8..597f043 100644
>> --- a/arch/arm/mach-rockchip/Kconfig
>> +++ b/arch/arm/mach-rockchip/Kconfig
>> @@ -3,6 +3,10 @@ if ARCH_ROCKCHIP
>>  config ROCKCHIP_RK3288
>>       bool "Support Rockchip RK3288"
>>       select CPU_V7
>> +     select SUPPORT_SPL
>> +     select SPL
>> +     select SPL_DM
>> +     select SPL_SYS_MALLOC_SIMPLE
>>       help
>>         The Rockchip RK3288 is a ARM-based SoC with a quad-core Cortex-A17
>>         including NEON and GPU, 1MB L2 cache, Mali-T7 graphics, two
>> @@ -13,12 +17,21 @@ config ROCKCHIP_RK3288
>>  config ROCKCHIP_RK3036
>>       bool "Support Rockchip RK3036"
>>       select CPU_V7
>> +     select SUPPORT_SPL
>> +     select SPL
>> +     select SPL_DM
>> +     select SPL_SYS_MALLOC_SIMPLE
>>       help
>>         The Rockchip RK3036 is a ARM-based SoC with a dual-core Cortex-A7
>>         including NEON and GPU, Mali-400 graphics, several DDR3 options
>>         and video codec support. Peripherals include Gigabit Ethernet,
>>         USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>
> looks like both you and Kever need that separation of the SPL symbols (me as
> well for the rk3188 for the time being), so it might make sense to split that
> out into a separate patch, all could use.
>
> I guess it might also make it easier for Simon to find an order to apply the
> patches?

Yes. Andreas, can you please resent your patches against u-boot-rockchip/master?

Also it needs a MAINTAINERS file I think.

Regards,
Simon