[U-Boot] cmd, nand: add an option to disable the verification when writing in raw mode

Boris Brezillon boris.brezillon at free-electrons.com
Mon Jul 25 11:18:28 CEST 2016


On Sun, 24 Jul 2016 20:41:30 -0500
Scott Wood <oss at buserror.net> wrote:

> On Wed, Jun 15, 2016 at 10:42:18AM +0200, Boris Brezillon wrote:
> > diff --git a/cmd/nand.c b/cmd/nand.c
> > index 583a18f..3a5e3a0 100644
> > --- a/cmd/nand.c
> > +++ b/cmd/nand.c
> > @@ -306,7 +306,7 @@ static void nand_print_and_set_info(int idx)
> >  }
> >  
> >  static int raw_access(struct mtd_info *mtd, ulong addr, loff_t off,
> > -		      ulong count, int read)
> > +		      ulong count, int read, int noverify)
> >  {
> >  	int ret = 0;
> >  
> > @@ -324,7 +324,7 @@ static int raw_access(struct mtd_info *mtd, ulong addr, loff_t off,
> >  			ret = mtd_read_oob(mtd, off, &ops);
> >  		} else {
> >  			ret = mtd_write_oob(mtd, off, &ops);
> > -			if (!ret)
> > +			if (!ret && !no_verify)
> >  				ret = nand_verify_page_oob(mtd, &ops, off);  
> 
> "noverify" versus "no_verify"...  I've fixed it while applying.

Oops, sorry about that.

> 
> I assume/hope that you just sent an old version by mistake, and that this
> was actually tested?

Yes, it was tested, just forgot to amend my commit :-(.
Thanks for fixing the problem.

Regards,

Boris




More information about the U-Boot mailing list