[U-Boot] [PATCH] i2c: intel_i2c: SMBus driver PCI addition (e.g. BayTrail)

[Stefan Roese]

Hi Simon,

On 25.07.2016 04:07, Simon Glass wrote:
> On 28 June 2016 at 07:44, Stefan Roese <sr at denx.de> wrote:
>> This patch adds support for the SMBus block read/write functionality.
>> Other protocols like the SMBus quick command need to get added
>> if this is needed.
>>
>> This patch also removed the SMBus related defines from the Ivybridge
>> pch.h header. As they are integrated in this driver and should be
>> used from here. This change is added in this patch to avoid compile
>> breakage to keep the source git bisectable.
>>
>> Tested on a congatec BayTrail board to configure the SMSC2513 USB
>> hub.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Bin Meng <bmeng.cn at gmail.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Heiko Schocher <hs at denx.de>
>> ---
>> Simon, I'm not sure if this change breaks your Ivybridge targets
>> using the probe part of this driver. Could you please let me
>> know if this works? Or let me know what needs changes here?
>
> Yes this breaks booting on link. Something odd is going on because the
> call to set up I2C in ivybridge's print_cpuinfo() returns a very
> strange error -726376.
>
> But I then enabled CONFIG_CMD_I2C and it boots. However 'i2c probe'
> produces a lot of errors like this:
>
> ERROR: len=0 on read
> smbus_block_read (107): dev=0x3b offs=0x0 len=0x1
> smbus_block_read (136): count=0 (len=1)

Thanks for checking. I'll try to find some time this week to look into
this.

Thanks,
Stefan