[U-Boot] [PATCH v2] spl_nor.c: Support devicetree sizes different from 16k

Tom Rini trini at konsulko.com
Tue Jul 26 14:27:01 CEST 2016


On Tue, Jul 26, 2016 at 8:24 AM, Mike Looijmans <mike.looijmans at topic.nl> wrote:
>
> On 26-07-16 14:10, Tom Rini wrote:
> > On Tue, Jul 26, 2016 at 07:34:07AM +0200, Mike Looijmans wrote:
> >
> >> The devicetrees for various platforms already exceed 16k. Add a define
> >> CONFIG_SYS_FDT_SIZE to specify the FDT size, and set to 16k for the
> >> two boards that define this CONFIG_SYS_FDT_BASE parameter. This
> >> allows platforms with larger devicetree blobs to boot from NOR.
> >>
> >> Signed-off-by: Mike Looijmans <mike.looijmans at topic.nl>
> >> ---
> >> v2: Instead of a default, just specify the value for the two boards that use it.
> >>   common/spl/spl_nor.c                 | 4 ++--
> >>   include/configs/a3m071.h             | 1 +
> >>   include/configs/microblaze-generic.h | 1 +
> >
> > This misses a few boards:
> > $ git grep SPL_NOR_SUPPORT include/configs
> > include/configs/a3m071.h:#define CONFIG_SPL_NOR_SUPPORT
> > include/configs/edminiv2.h:#define CONFIG_SPL_NOR_SUPPORT
> > include/configs/microblaze-generic.h:# define CONFIG_SPL_NOR_SUPPORT
> > include/configs/uniphier.h:#define CONFIG_SPL_NOR_SUPPORT
> > include/configs/x600.h:#define CONFIG_SPL_NOR_SUPPORT
> >
> > Please update, thanks!
> >
>
> Only boards that define "CONFIG_SYS_FDT_BASE" need to set
> "CONFIG_SYS_FDT_SIZE", since CONFIG_SYS_FDT_BASE is required as second arg for
> the memcpy call, boards that don't define it apparently don't support booting
> directly from NOR. Apparently, of the five boards with SPL_NOR support, only
> these two boards support booting into a kernel directly:
>
> $ grep -r CONFIG_SYS_FDT_BASE *
> common/spl/spl_nor.c:          (void *)(CONFIG_SYS_FDT_BASE),
> include/configs/a3m071.h:#define CONFIG_SYS_FDT_BASE 0xfc1e0000
> include/configs/a3m071.h: "fdt_addr=" __stringify(CONFIG_SYS_FDT_BASE) "\0"  \
> include/configs/microblaze-generic.h:#define CONFIG_SYS_FDT_BASE
> (CONFIG_SYS_FLASH_BASE + \

Ah, OK, thanks!

-- 
Tom


More information about the U-Boot mailing list