[U-Boot] [PATCH] usb: dwc3: fixes crash in dwc3 driver due to types size mismatch

B, Ravi ravibabu at ti.com
Tue Jul 26 14:59:14 CEST 2016


Tom

>> based on phys_addr_t, so it triggered
>> the problem for DWC3, which had already potentially existed.
>> 
>> 
>> CONFIGs in Kconfig are guaranteed to be defined for all files, but 
>> CONFIGs in board headers are not.
>> 
>> So we need to make sure to add
>> #include <common.h> (or #include <config.h>) in each source file.
>>
>> 
>> So, your patch is doing a right thing.
>> 
>> I will issue my Reviewed-by when you update the git-log.
>> 
>> 
>> (Moving CONFIG_PHYS_64BIT is a right thing as well)

>Can we move PHYS_64BIT to Kconfig instead here please?  This is the kind of thing we should be able to select based on SoC / board.  Thanks!

Yes, moving to PHYS_64BIT to Kconfig would be ideal fix. Thanks for pointing out. 

I have posted patch.  
Commit: bac9e0: Kconfig: dra7x: Kconfig based PHYS_64BIT select based on Soc type 

Regards
Ravi 


More information about the U-Boot mailing list