[U-Boot] [PATCH 2/2] uniphier: Drop CONFIG_I2C_EEPROM

[Masahiro Yamada]

Hi Tom,


2016-07-26 11:23 GMT+09:00 Tom Rini <trini at konsulko.com>:
> On Tue, Jul 26, 2016 at 11:07:02AM +0900, Masahiro Yamada wrote:
>> Hi Tom,
>>
>> 2016-07-26 7:21 GMT+09:00 Tom Rini <trini at konsulko.com>:
>> > This option was set in the main uniphier config file, but was not
>> > causing the driver to be built, so we just drop the line here.
>> >
>>
>> This option is actually causing drivers/misc/i2c_eeprom.o built,
>> and I really need it.
>
> Interesting.  I tried uniphier_ld4_sld8 and it was not.

It is.


masahiro at grover:~/workspace/u-boot$ make mrproper
masahiro at grover:~/workspace/u-boot$ git describe
v2016.09-rc1
masahiro at grover:~/workspace/u-boot$ make uniphier_ld4_sld8_defconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
masahiro at grover:~/workspace/u-boot$ make CROSS_COMPILE=arm-linux-gnueabi-
scripts/kconfig/conf  --silentoldconfig Kconfig
  [ snip ]
  LD      drivers/memory/built-in.o
  CC      drivers/misc/i2c_eeprom.o
  LD      drivers/misc/built-in.o




>  And
> moveconfig.py also didn't see it needed.

This is correct behavior.


config I2C_EEPROM
        bool "Enable driver for generic I2C-attached EEPROMs"
        depends on MISC


This option depends on "MISC".
So, it is invisible unless MISC is defined.





> [snip]
>> Could you move the config to Kconfig rather than removing it, please?
>
> I'll drop this patch and now that you're aware of it, let you handle it.
> Especially since moveconfig.py isn't seeing it :)  Thanks!

I handled it.
http://patchwork.ozlabs.org/patch/652880/


It is a trivial move,
could you pick it up directly to u-boot/master?


-- 
Best Regards
Masahiro Yamada